Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swaps wdio for Playwright #1617

Closed
wants to merge 1 commit into from
Closed

Swaps wdio for Playwright #1617

wants to merge 1 commit into from

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Mar 31, 2023

3/31 - Playwright throws an error when uploading the artifact to Sauce. Looks like something related to docker, but I'm not sure :(

This is a test PR for what swapping to Playwright instead of wdio might look like.

Changes

  • Swaps tests to use playwright instead of wdio

Testing

  1. PR checks should pass.
  2. yarn test:browser should run playwright locally.

@netlify
Copy link

netlify bot commented Mar 31, 2023

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 49cefec
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/6426e379053c460008e704c1
😎 Deploy Preview https://deploy-preview-1617--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 31, 2023

Thanks for the improvements! Browse a preview of your changes using the link below.

Name Link
🔨 Latest commit 68e0f6c
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system/deploys/6515ce8bb8b72300084b0ab9
😎 Deploy Preview https://deploy-preview-1617--cfpb-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anselmbradford
Copy link
Member Author

Running yarn test:browser:cloud locally throws the error:

app.zip panic: runtime error: invalid memory address or nil pointer dereference

I'm not sure why.

@anselmbradford anselmbradford changed the title Swaps playwright for wdio Swaps wdio for Playwright Mar 31, 2023
@anselmbradford
Copy link
Member Author

Sauce CI failure is because of saucelabs/sauce-playwright-runner#202

@anselmbradford
Copy link
Member Author

Comparing this to webdriver on main, the tests are 30.06s for webdriver and 55.42s for Playwright, so unlikely we would want to switch at the current configuration.

@anselmbradford anselmbradford force-pushed the ans_playwright branch 2 times, most recently from c0ede13 to 343ee1a Compare July 28, 2023 13:21
@anselmbradford anselmbradford force-pushed the ans_playwright branch 3 times, most recently from 1410962 to 695a6c2 Compare September 14, 2023 16:49
@anselmbradford
Copy link
Member Author

Closing in favor of #1871

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold lerna-changelog/internal lerna label. DO NOT MODIFY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant